[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87pm6km1lr.wl-kuninori.morimoto.gx@renesas.com>
Date: Mon, 29 May 2023 00:18:48 +0000
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-iio@...r.kernel.org,
Christophe Leroy <christophe.leroy@...roup.eu>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 9/9] ASoC: simple-card: Handle additional devices
Hi Herve
Thank you for the reply
> > static int __simple_for_each_link (...)
> > {
> > ...
> > => add_devs = of_get_child_by_name(top, PREFIX "additional-devs");
> > ...
> > }
> >
> > static int simple_populate_aux(...)
> > {
> > ...
> > => node = of_get_child_by_name(dev->of_node, PREFIX "additional-devs");
> > ...
> > }
> >
>
> Well, of_get_child_by_name() is called twice to retrieve the additional-devs
> node but for very different reason.
>
> In __simple_for_each_link() to filter out the node as it has nothing to do with a DAI.
> In simple_populate_aux() to take care of the devices declared in the node.
I thought it is better to handling "device" and "filtering" in the same place,
if it has "additional-devs" on the DT. Because we don't need to filtering
if don't need to care about device.
But this is very small detail, not a big deal to discuss about for
a long time.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
Powered by blists - more mailing lists