linux-kernel - Re: [PATCH linux-next] ARM: unwind: use ex_frame with CONFIG_UNWINDER_FRAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdayo8ZOm8BJxPSt6g0n-auFsTV7m6RNP6XoqHTM2qRMPw@mail.gmail.com>
Date:   Mon, 29 May 2023 11:46:40 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     guo.ziliang@....com.cn
Cc:     linux@...linux.org.uk, rmk+kernel@...linux.org.uk,
        lihuafei1@...wei.com, broonie@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re:  [PATCH linux-next] ARM: unwind: use ex_frame with CONFIG_UNWINDER_FRAME_POINTER

On Thu, May 18, 2023 at 10:58 AM <guo.ziliang@....com.cn> wrote:

> From: guo ziliang <guo.ziliang@....com.cn>
>
> We define ex_frame with CONFIG_UNWINDER_FRAME_POINTER in struct stackframe,
> struct stackframe
> {
>         ......
> #ifdef CONFIG_UNWINDER_FRAME_POINTER
>     bool ex_frame;
> #endif
> };
> but we just use ex_frame without CONFIG_UNWINDER_FRAME_POINTER in
> return_address() and unwind_frame().
> Maybe we should fix it.
>
> Signed-off-by: guo ziliang <guo.ziliang@....com.cn>

Looks reasonable:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Is it possible to create a .config which expose this problem?
Then mention in the commit message "if you select A and B
then compilation fails..."

Yours,
Linus Walleij