linux-kernel - Re: [PATCH] soc: xilinx: Fix a memory leak in zynqmp_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8355a10b-e365-485f-810f-0c3001a0406a@kili.mountain>
Date:   Mon, 29 May 2023 12:59:42 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Michal Simek <michal.simek@....com>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Tejas Patel <tejas.patel@...inx.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] soc: xilinx: Fix a memory leak in zynqmp_pm_remove()

On Mon, May 29, 2023 at 09:53:24AM +0200, Christophe JAILLET wrote:
> 'rx_chan' is known to be NULL here.
> Reverse the logic to free the mbox if it has been allocated.
> 
> Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> 'rx_chan' may be NULL, but mbox_free_channel() handles it.
> Maybe it is more informative to keep a (useless) "if (rx_chan)" to tell
> that it may not be allocated.
> 
> 
> On my machine, compilation fails with gcc (Ubuntu 12.1.0-2ubuntu1~22.04):
> 
>   CC      drivers/soc/xilinx/zynqmp_power.o
> drivers/soc/xilinx/zynqmp_power.c: In function ‘zynqmp_pm_probe’:
> drivers/soc/xilinx/zynqmp_power.c:193:12: error: ‘pm_api_version’ is used uninitialized [-Werror=uninitialized]
>   193 |         if (pm_api_version < ZYNQMP_PM_VERSION)
>       |            ^
> drivers/soc/xilinx/zynqmp_power.c:187:13: note: ‘pm_api_version’ was declared here
>   187 |         u32 pm_api_version;
>       |             ^~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> I think that this warning is bogus and gcc is wrong.
> 
> But I don't know what to do with it :/
> Anyway, it is un-realated to this patch.

I bet GCC is correct.

Do you have CONFIG_ZYNQMP_FIRMWARE enabled in your .config?  This driver
can only be compiled with that enabled, but I've seen some of your
other patches depend on CONFIG_BROKEN so I think you're going outside of
the Kconfig rules.

regards,
dan carpenter