linux-kernel - Re: [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0g2=iYThmRzJXofUXSMrVPM-T2Ck8-HxiS=2_cn3Hv52g@mail.gmail.com>
Date:   Mon, 29 May 2023 16:13:25 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Robert Moore <robert.moore@...el.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-acpi@...r.kernel.org,
        acpica-devel@...ts.linuxfoundation.org
Subject: Re: [PATCH] ACPICA: Slightly simplify an error message in acpi_ds_result_push()

On Mon, May 29, 2023 at 8:31 AM Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:
>
> 'object' is known to be NULL at this point. There is little value to log
> it twice in the error message.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

ACPICA changes require (at least) a pull request submitted to the
upstream ACPICA project on GitHub.

If you have submitted one, please resend the Linux patch with a Link
tag pointing to the corresponding upstream ACPICA pull request.

Thanks!

> ---
>  drivers/acpi/acpica/dswstate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/dswstate.c b/drivers/acpi/acpica/dswstate.c
> index d3841ded3a81..75338a13c802 100644
> --- a/drivers/acpi/acpica/dswstate.c
> +++ b/drivers/acpi/acpica/dswstate.c
> @@ -146,8 +146,8 @@ acpi_ds_result_push(union acpi_operand_object *object,
>
>         if (!object) {
>                 ACPI_ERROR((AE_INFO,
> -                           "Null Object! Obj=%p State=%p Num=%u",
> -                           object, walk_state, walk_state->result_count));
> +                           "Null Object! State=%p Num=%u",
> +                           walk_state, walk_state->result_count));
>                 return (AE_BAD_PARAMETER);
>         }
>
> --
> 2.34.1
>