linux-kernel - Re: [PATCH v3 4/5] platform/x86: think-lmi: Don't display unnecessary authentication settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <49631ff4-8d8c-4e77-bf13-dd8b0c1819d0@app.fastmail.com>
Date:   Mon, 29 May 2023 10:50:35 -0400
From:   "Mark Pearson" <mpearson-lenovo@...ebb.ca>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     "Hans de Goede" <hdegoede@...hat.com>,
        "markgross@...nel.org" <markgross@...nel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/5] platform/x86: think-lmi: Don't display unnecessary
 authentication settings



On Mon, May 29, 2023, at 8:05 AM, Ilpo Järvinen wrote:
> On Fri, 26 May 2023, Mark Pearson wrote:
>
>> If Opcode support is available (which is the standard for all platforms
>> going forward) then there is no need to have the encoding and kbdlang
>> attributes visible
>> 
>> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
>> ---
>> Changes in v2 & v3: None. Version bumped in series
>> 
>>  drivers/platform/x86/think-lmi.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
>> index 1c02958035ad..64cd453d6e7d 100644
>> --- a/drivers/platform/x86/think-lmi.c
>> +++ b/drivers/platform/x86/think-lmi.c
>> @@ -879,6 +879,12 @@ static umode_t auth_attr_is_visible(struct kobject *kobj,
>>  		return 0;
>>  	}
>>  
>> +	/* Don't display un-needed settings if opcode available */
>> +	if ((attr == &auth_encoding.attr ||
>> +	    attr == &auth_kbdlang.attr) &&
>
> Indentation issue here, attr must be at the same column although putting 
> the || on a single line might make this easier to read.

OK - will fix.

>
>> +	    tlmi_priv.opcode_support)
>> +		return 0;
>> +
>>  	return attr->mode;
>>  }
>>  
>> 
>
> -- 
>  i.

Thanks for the review
Mark