linux-kernel - Re: [linus:master] [tpm, tpm_tis] e644b2f498: RIP:acpi_safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcdc5a27817b17d91df84bb06ad5d382829d5467.camel@mniewoehner.de>
Date:   Mon, 29 May 2023 17:07:54 +0200
From:   Michael Niewöhner <linux@...ewoehner.de>
To:     Jerry Snitselaar <jsnitsel@...hat.com>,
        Lino Sanfilippo <l.sanfilippo@...bus.com>
Cc:     Lukas Wunner <lukas@...ner.de>,
        Jarkko Sakkinen <jarkko@...nel.org>, oe-lkp@...ts.linux.dev,
        lkp@...el.com, linux-kernel@...r.kernel.org,
        linux-integrity@...r.kernel.org,
        Philipp Rosenberger <p.rosenberger@...bus.com>,
        peterz@...radead.org
Subject: Re: [linus:master] [tpm, tpm_tis] e644b2f498: RIP:acpi_safe_halt

Hi Jerry,

On Thu, 2023-05-11 at 07:59 -0700, Jerry Snitselaar wrote:
> 
> IIRC trying to catch the irq storm didn't work in the L490 case for
> some reason, so we might still need the dmi entry for that one.
> 
> The info that the T490s had a pin wired up wrong came from Lenovo, but
> this one even looks to be a different vendor so I wonder how often
> this happens or if there is something else going on. Is it possible to
> get info about the tpm used in the Inspur system? The datasheet online
> doesn't mention it.

Are you sure about T490s? To me the wiring looks right on both s and non-s: Pin
18 / PIRQ# goes to PIRQA# of the PCH/SoC.

However on L490 Pin 18 / PIRQ# is wired wrongly to SERIRQ, which probably is the
reason that catching the interrupt storm didn't work: I guess this completely
messes up LPC communication and causes way more problems. In this case only a
DMI quirk can help.

BR
Michael

> 
> Regards,
> Jerry
> 
> > > Thanks,
> > > 
> > > Lukas
>