[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <eb9d9814-2dd4-ee87-b1ca-4660b59abec4@gmail.com>
Date: Mon, 29 May 2023 18:18:30 +0200
From: Matthias Brugger <matthias.bgg@...il.com>
To: Frank Wunderlich <linux@...web.de>,
linux-mediatek@...ts.infradead.org
Cc: Frank Wunderlich <frank-w@...lic-files.de>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, stable@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: mt7986: use size of reserved partition for
bl2
On 28/05/2023 13:33, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@...lic-files.de>
>
> To store uncompressed bl2 more space is required than partition is
> actually defined.
>
> There is currently no known usage of this reserved partition.
> Openwrt uses same partition layout.
>
> We added same change to u-boot with commit d7bb1099 [1].
>
> [1] https://source.denx.de/u-boot/u-boot/-/commit/d7bb109900c1ca754a0198b9afb50e3161ffc21e
>
> Cc: stable@...r.kernel.org
> Fixes: 8e01fb15b815 ("arm64: dts: mt7986: add Bananapi R3")
> Signed-off-by: Frank Wunderlich <frank-w@...lic-files.de>
Applied, thanks!
> ---
> If the bl2 does not fit into the bl2-partition (cut off), board does
> not boot, thats why i want to increase it now. My current bl2 is 197K
> for nor and i ran into this problem.
>
> Openwrt uses also the first reserved partition to give bl2 more
> space:
>
> https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/mediatek/dts/mt7986a-bananapi-bpi-r3-nor.dts;h=f597b869abc80d1a73f44ebb85ad4da17376bb52;hb=HEAD#l22
>
> so imho it should be same in mainline to not require complex bl2
> compression.
>
> have now sent the board-specific dts to uboot too:
> https://source.denx.de/u-boot/u-boot/-/commit/d7bb109900c1ca754a0198b9afb50e3161ffc21e
> ---
> .../boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dtso | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dtso b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dtso
> index 84aa229e80f3..e48881be4ed6 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dtso
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-nor.dtso
> @@ -27,15 +27,10 @@ partitions {
>
> partition@0 {
> label = "bl2";
> - reg = <0x0 0x20000>;
> + reg = <0x0 0x40000>;
> read-only;
> };
>
> - partition@...00 {
> - label = "reserved";
> - reg = <0x20000 0x20000>;
> - };
> -
> partition@...00 {
> label = "u-boot-env";
> reg = <0x40000 0x40000>;
Powered by blists - more mailing lists