linux-kernel - Re: [PATCH v2 1/1] vfio/nvgpu: Add vfio pci variant module for grace hopper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHTjEgXPHhTKtT4N@nvidia.com>
Date:   Mon, 29 May 2023 14:38:26 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Alex Williamson <alex.williamson@...hat.com>
Cc:     ankita@...dia.com, aniketa@...dia.com, cjia@...dia.com,
        kwankhede@...dia.com, targupta@...dia.com, vsethi@...dia.com,
        acurrid@...dia.com, apopple@...dia.com, jhubbard@...dia.com,
        danw@...dia.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        yishaih@...dia.com, shameerali.kolothum.thodi@...wei.com,
        kevin.tian@...el.com
Subject: Re: [PATCH v2 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper

On Thu, May 25, 2023 at 09:21:23AM -0600, Alex Williamson wrote:
> On Tue, 16 May 2023 21:28:35 -0300
> Jason Gunthorpe <jgg@...dia.com> wrote:
> 
> > On Tue, May 16, 2023 at 03:09:14PM -0600, Alex Williamson wrote:
> > 
> > > > +# SPDX-License-Identifier: GPL-2.0-only
> > > > +config NVGPU_VFIO_PCI
> > > > +	tristate "VFIO support for the GPU in the NVIDIA Grace Hopper Superchip"
> > > > +	depends on ARM64 || (COMPILE_TEST && 64BIT)
> > > > +	select VFIO_PCI_CORE  
> > > 
> > > I think this should be a 'depends on' as well, that's what we have for
> > > the other vfio-pci variant drivers.  
> > 
> > It should be removed completely, AFAICT:
> > 
> > config VFIO_PCI
> >         tristate "Generic VFIO support for any PCI device"
> >         select VFIO_PCI_CORE
> > 
> > Ensures it is turned on
> > 
> > if VFIO_PCI
> > source "drivers/vfio/pci/mlx5/Kconfig"
> > endif
> 
> The source command actually comes after the VFIO_PCI endif, the mlx5
> Kconfig is sourced if PCI && MMU.

Ah, I forgot we made the VFIO_PCI_CORE a hidden menu choice, so yeah,
it should be select everywhere and we can't use the IF trick.

> In fact I think it's the current variant drivers that are incorrect to
> make use of 'depends on', this makes those variant drivers implicitly
> depend on VFIO_PCI

Yes

Jason