linux-kernel - Re: [PATCH v1 1/1] nvme: complete directly for hctx with only one ctx mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGaU9a85dmzuvozHMWj4n93gfwt4Xj1qoYi2oyY_3Tcc+bFg7g@mail.gmail.com>
Date:   Tue, 30 May 2023 10:49:35 +0800
From:   Stanley Chu <chu.stanley@...il.com>
To:     Po-Wen Kao <powen.kao@...iatek.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, Jens Axboe <axboe@...nel.dk>,
        Keith Busch <kbusch@...nel.org>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        wsd_upstream@...iatek.com, peter.wang@...iatek.com,
        stanley.chu@...iatek.com, alice.chao@...iatek.com,
        naomi.chu@...iatek.com, chun-hung.wu@...iatek.com,
        cc.chou@...iatek.com, eddie.huang@...iatek.com,
        Ed Tsai <ed.tsai@...iatek.com>, linux-block@...r.kernel.org,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v1 1/1] nvme: complete directly for hctx with only one ctx mapping

On Tue, May 30, 2023 at 10:45 AM Po-Wen Kao <powen.kao@...iatek.com> wrote:
>
> From: Ed Tsai <ed.tsai@...iatek.com>
>
> Refer to
> commit f168420c62e7
> ("blk-mq: don't redirect completion for hctx withs only one ctx mapping")
> When nvme applies a 1:1 mapping of hctx and ctx, there will be no remote
> request.
>
> But for ufs, the submission and completion queue could be asymmetric.
> (e.g. Multiple SQs share one CQ) Therefore, 1:1 mapping of hctx and
> ctx won't complete request on the submission cpu. In this situation,
> put this condition in block layer could violate the
> QUEUE_FLAG_SAME_FORCE, as a result, move this back to nvme.
>
> Signed-off-by: Ed Tsai <ed.tsai@...iatek.com>
> Signed-off-by: Po-Wen Kao <powen.kao@...iatek.com>

Reviewed-by: Stanley Chu <stanley.chu@...iatek.com>