linux-kernel - Re: [PATCH] riscv: vector: Fixup modules compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 May 2023 10:59:14 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Conor Dooley <conor.dooley@...rochip.com>
Cc:     greentime.hu@...ive.com, vincent.chen@...ive.com,
        andy.chiu@...ive.com, paul.walmsley@...ive.com,
        palmer@...osinc.com, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH] riscv: vector: Fixup modules compile error

On Mon, May 29, 2023 at 9:43 PM Conor Dooley <conor.dooley@...rochip.com> wrote:
>
> On Mon, May 29, 2023 at 03:38:45AM -0400, guoren@...nel.org wrote:
> > From: Guo Ren <guoren@...ux.alibaba.com>
> >
> > Some .ko also need the riscv_v_user_allowed symbol.
> >
> > ERROR: modpost: "riscv_v_user_allowed" [arch/riscv/kvm/kvm.ko]
> > undefined!
> > make[3]: ***
> > [/home/guoren/source/kernel/linux/scripts/Makefile.modpost:136:
> > Module.symvers] Error 1
> >
> > Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> > Signed-off-by: Guo Ren <guoren@...nel.org>
> > ---
> >  arch/riscv/kernel/vector.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/riscv/kernel/vector.c b/arch/riscv/kernel/vector.c
> > index 1c4ac821e008..3ae08816d608 100644
> > --- a/arch/riscv/kernel/vector.c
> > +++ b/arch/riscv/kernel/vector.c
> > @@ -129,6 +129,7 @@ bool riscv_v_user_allowed(void)
> >  {
> >       return riscv_v_get_cur_ctrl(current) == PR_RISCV_V_VSTATE_CTRL_ON;
> >  }
> > +EXPORT_SYMBOL(riscv_v_user_allowed);
>
> Is there a reason that this should not be EXPORT_SYMBOL_GPL()?
Good question, but I just follow our arch/riscv habbit, maybe we
should change all of that in another patch.

➜  linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL  arch/riscv -r | wc -l
66
➜  linux-s64ilp32 git:(s64ilp32) ✗ grep EXPORT_SYMBOL_GPL  arch/riscv -r | wc -l
15

>
> I figure Andy will roll this into this next revision.
>
> Cheers,
> Conor.



-- 
Best Regards
 Guo Ren