linux-kernel - Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR03MB53725BBA63A682EB14050FC9F04B9@DM6PR03MB5372.namprd03.prod.outlook.com>
Date:   Tue, 30 May 2023 14:55:49 +0000
From:   Ross Lagerwall <ross.lagerwall@...rix.com>
To:     Jan Beulich <jbeulich@...e.com>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>, Juergen Gross <jgross@...e.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Peter Jones <pjones@...hat.com>,
        Konrad Rzeszutek Wilk <konrad@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0

> From: Jan Beulich <jbeulich@...e.com>
> Sent: Thursday, May 25, 2023 10:31 AM
> To: Ross Lagerwall <ross.lagerwall@...rix.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>; Ingo Molnar <mingo@...hat.com>; Borislav Petkov <bp@...en8.de>; Dave Hansen <dave.hansen@...ux.intel.com>; x86@...nel.org <x86@...nel.org>; Juergen Gross <jgross@...e.com>; Boris Ostrovsky <boris.ostrovsky@...cle.com>; Peter Jones <pjones@...hat.com>; Konrad Rzeszutek Wilk <konrad@...nel.org>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; xen-devel@...ts.xenproject.org <xen-devel@...ts.xenproject.org>
> Subject: Re: [PATCH] iscsi_ibft: Fix finding the iBFT under Xen Dom 0 
>  
> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments unless you have verified the sender and know the content is safe.
> 
> On 24.05.2023 18:05, Ross Lagerwall wrote:
> > --- a/arch/x86/xen/setup.c
> > +++ b/arch/x86/xen/setup.c
> > @@ -772,8 +772,14 @@ char * __init xen_memory_setup(void)
> >         * UNUSABLE regions in domUs are not handled and will need
> >         * a patch in the future.
> >         */
> 
> I think this comment now wants to move ...
> 
> > -     if (xen_initial_domain())
> > +     if (xen_initial_domain()) {
> 
> ... here. And then likely you want a blank line ...
> 
> >                xen_ignore_unusable();
> 
> ... here.

OK

> 
> > +             /* Reserve 0.5 MiB to 1 MiB region so iBFT can be found */
> > +             xen_e820_table.entries[xen_e820_table.nr_entries].addr = 0x80000;
> > +             xen_e820_table.entries[xen_e820_table.nr_entries].size = 0x80000;
> > +             xen_e820_table.entries[xen_e820_table.nr_entries].type = E820_TYPE_RESERVED;
> > +             xen_e820_table.nr_entries++;
> 
> Surely this can be omitted when !CONFIG_ISCSI_IBFT_FIND?
> 

Yes, good point. I will fix that.

Thanks,
Ross