linux-kernel - Re: [PATCH v6] usb: common: usb-conn-gpio: Set last role to unknown before initial detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <498a0b96-4c40-cad6-8da7-e9819035ef22@quicinc.com>
Date:   Tue, 30 May 2023 20:56:26 +0530
From:   Prashanth K <quic_prashk@...cinc.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6] usb: common: usb-conn-gpio: Set last role to unknown
 before initial detection



On 30-05-23 07:58 pm, Greg Kroah-Hartman wrote:
> On Tue, May 30, 2023 at 10:14:31AM +0530, Prashanth K wrote:
>> Currently if we bootup a device without cable connected, then
>> usb-conn-gpio won't call set_role() since last_role is same as
>> current role. This happens because during probe last_role gets
>> initialised to zero.
>>
>> To avoid this, added a new constant in enum usb_role, last_role
>> is set to USB_ROLE_UNKNOWN before performing initial detection.
>>
>> While at it, also handle default case for the usb_role switch
>> in cdns3 to avoid build warnings.
>>
>> Fixes: 4602f3bff266 ("usb: common: add USB GPIO based connection detection driver")
>> Signed-off-by: Prashanth K <quic_prashk@...cinc.com>
> 
> Breaks the build :(
> 
> Please be more careful when submitting stuff, especially on v6 of a
> patch :(

Hi, sorry for the trouble, I didn't see any issue in while building 
locally nor any warning/errors from test robot. Can you please point me 
to the error report if available. If the build is breaking due to enum 
value USB_ROLE_UNKNOWN unhandled in switch cases of other drivers, then 
i will revert thing back to v1 where i used a macro for USB_ROLE_UNKNOWN 
in usb-conn-gpio driver. Something like this in usb-conn-gpio.c would 
can help us avoid adding default case in other drivers using usb_role.

#define USB_ROLE_UNKNWON (USB_ROLE_NONE - 1)

Please let me know.

Thanks,
Prashanth K