linux-kernel - Re: [PATCH] clocksource/drivers/imx-gpt: Use only a single name for functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d0c2a64-9260-02b1-b2af-0cea4983d5b7@linaro.org>
Date:   Tue, 30 May 2023 18:18:06 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/imx-gpt: Use only a single name for
 functions

On 30/05/2023 17:31, Uwe Kleine-König wrote:
> Helo Daniel,
> 
> On Tue, Mar 28, 2023 at 11:15:14AM +0200, Uwe Kleine-König wrote:
>> When looking at the data structs defining the different behaviours of
>> the GPT blocks in different SoCs it's not helpful that the same
>> functions are used with different names.
>>
>> So drop the cpp defines and use the original names.
>>
>> This commit was generated using:
>>
>> 	perl -i -e 'my %m; while (<>) { if (/^#define (imx[a-zA-Z0-6_]*)\s(imx[a-zA-Z0-6_]*)/) {$m{$1} = $2; } else { foreach my $f (keys %m) {s/$f/$m{$f}/; } print; } }' drivers/clocksource/timer-imx-gpt.c
>>
>> This patch has no effect on the generated code.
>>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> This patch was generated against v6.3-rc1. On the upside it still
> applies fine to v6.4-rc1 and even current next/master. On the downside I
> didn't get any feedback on it. Is this patch still on your radar?

Well, it is back on the radar now :)

Without feedback from the driver maintainer I'll pick the patch in a few 
days


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog