linux-kernel - Re: [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same line with else if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee41bf67-a074-49fd-bd0f-7fb992d68884@kili.mountain>
Date:   Tue, 30 May 2023 07:15:26 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Deepanshu Kartikey <kartikey406@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same
 line with else if

On Tue, May 30, 2023 at 07:52:59AM +0530, Deepanshu Kartikey wrote:
>  drivers/staging/rts5208/rtsx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index 2284a96abcff..47dacef0aaf8 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
>  				chip->srb->device->id,
>  				(u8)chip->srb->device->lun);
>  			chip->srb->result = DID_BAD_TARGET << 16;
> -		}
> -
> -		/* we've got a command, let's do it! */
> -		else {
> +		} else {
> +			/* we've got a command, let's do it! */

This code is part of series of if else statements that all have the
same issue but you're only changing one.  Please change them all.

regards,
dan carpenter