linux-kernel - Re: [PATCH] dma-mapping: Name SG DMA flag helpers consistently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a411404-a2fc-694c-c41e-5d7efba38472@deltatee.com>
Date:   Tue, 30 May 2023 11:23:12 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Robin Murphy <robin.murphy@....com>, hch@...radead.org
Cc:     m.szyprowski@...sung.com, iommu@...ts.linux.dev,
        catalin.marinas@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma-mapping: Name SG DMA flag helpers consistently



On 2023-05-25 11:46, Robin Murphy wrote:
> sg_is_dma_bus_address() is inconsistent with the naming pattern of its
> corresponding setters and its own kerneldoc, so take the majority vote
> and rename it sg_dma_is_bus_address() (and fix up the missing
> underscores in the kerneldoc too). This gives us a nice clear pattern
> where SG DMA flags are SG_DMA_<NAME>, and the helpers for acting on them
> are sg_dma_<action>_<name>().
> 
> Signed-off-by: Robin Murphy <robin.murphy@....com>

Looks good to me. Thanks.

Reviewed-by: Logan Gunthorpe <logang@...tatee.com>