linux-kernel - Re: [PATCH] mm: page_alloc: remove unneeded header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230530151306.b9f24b247c66ea7f80df6be8@linux-foundation.org>
Date:   Tue, 30 May 2023 15:13:06 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: page_alloc: remove unneeded header files

On Sat, 27 May 2023 18:07:28 +0800 Miaohe Lin <linmiaohe@...wei.com> wrote:

> Remove some unneeded header files. No functional change intended.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  mm/page_alloc.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index e671c747892f..beb6db613238 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -24,9 +24,7 @@
>  #include <linux/kernel.h>
>  #include <linux/kasan.h>
>  #include <linux/kmsan.h>
> -#include <linux/module.h>

This contains the prototype for print_modules().  So we're now reliant
upon module.h being included via some other header, which is fragile.

>  #include <linux/suspend.h>
> -#include <linux/pagevec.h>
>  #include <linux/ratelimit.h>
>  #include <linux/oom.h>
>  #include <linux/topology.h>
> @@ -36,8 +34,6 @@
>  #include <linux/memory_hotplug.h>
>  #include <linux/nodemask.h>
>  #include <linux/vmstat.h>
> -#include <linux/sort.h>
> -#include <linux/pfn.h>
>  #include <linux/fault-inject.h>
>  #include <linux/compaction.h>
>  #include <trace/events/kmem.h>
> @@ -52,11 +48,9 @@
>  #include <linux/memcontrol.h>
>  #include <linux/ftrace.h>
>  #include <linux/lockdep.h>
> -#include <linux/nmi.h>
>  #include <linux/psi.h>
>  #include <linux/khugepaged.h>
>  #include <linux/delayacct.h>
> -#include <asm/div64.h>

Needed for do_div()?

>  #include "internal.h"
>  #include "shuffle.h"
>  #include "page_reporting.h"
> -- 
> 2.27.0