linux-kernel - Re: [PATCH stable 6.3 v2] arch_topology: Remove early cacheinfo error message if -ENOENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <72d84100-55cf-566d-8301-7147ce14b1e9@broadcom.com>
Date:   Tue, 30 May 2023 15:42:45 -0700
From:   Florian Fainelli <florian.fainelli@...adcom.com>
To:     Conor Dooley <conor@...nel.org>
Cc:     stable@...r.kernel.org, Pierre Gondois <pierre.gondois@....com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "open list:GENERIC ARCHITECTURE TOPOLOGY" 
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH stable 6.3 v2] arch_topology: Remove early cacheinfo error
 message if -ENOENT

Hi Conor,

On 5/30/23 14:39, Conor Dooley wrote:
> Yo Florian,
> 
> On Tue, May 30, 2023 at 01:19:55PM -0700, Florian Fainelli wrote:
>> From: Pierre Gondois <pierre.gondois@....com>
>>
>> commit 3522340199cc060b70f0094e3039bdb43c3f6ee1 upstream
>>
>> fetch_cache_info() tries to get the number of cache leaves/levels
>> for each CPU in order to pre-allocate memory for cacheinfo struct.
>> Allocating this memory later triggers a:
>>    'BUG: sleeping function called from invalid context'
>> in PREEMPT_RT kernels.
>>
>> If there is no cache related information available in DT or ACPI,
>> fetch_cache_info() fails and an error message is printed:
>>    'Early cacheinfo failed, ret = ...'
>>
>> Not having cache information should be a valid configuration.
>> Remove the error message if fetch_cache_info() fails with -ENOENT.
>>
>> Suggested-by: Conor Dooley <conor.dooley@...rochip.com>
>> Link: https://lore.kernel.org/all/20230404-hatred-swimmer-6fecdf33b57a@spud/
>> Signed-off-by: Pierre Gondois <pierre.gondois@....com>
>> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
>> Link: https://lore.kernel.org/r/20230414081453.244787-4-pierre.gondois@arm.com
>> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
>> Signed-off-by: Florian Fainelli <florian.fainelli@...adcom.com>
> 
> How come this now needs a backport? Did the rest of the series get
> backported, but not this one since it has no fixes tag?

Humm, indeed, this has been present in v6.3.2 since I requested it to be 
included. The error that I saw this morning was not -ENOENT, but -EINVAL.

With those patches applied, no more -EINVAL:

cacheinfo: Allow early level detection when DT/ACPI info is missing/broken
cacheinfo: Add arm64 early level initializer implementation
cacheinfo: Add arch specific early level initializer
cacheinfo: Add use_arch[|_cache]_info field/function

I will submit those shortly unless we think they better not be in 6.3, 
in which case it would be nice to silence those -EINVAL errors.
-- 
Florian


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)