[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7a1a3ac3-10ec-9935-bca1-023cec6c0024@microchip.com>
Date: Tue, 30 May 2023 07:06:04 +0000
From: <Claudiu.Beznea@...rochip.com>
To: <walker.chen@...rfivetech.com>, <broonie@...nel.org>,
<lgirdwood@...il.com>, <perex@...ex.cz>, <tiwai@...e.com>,
<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
<Conor.Dooley@...rochip.com>, <emil.renner.berthing@...onical.com>,
<hal.feng@...rfivetech.com>
CC: <alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v5 2/3] ASoC: starfive: Add JH7110 TDM driver
On 30.05.2023 09:47, Claudiu Beznea - M18063 wrote:
>> + #define CLKPOL_BIT 5
>> + #define TRITXEN_BIT 4
>> + #define ELM_BIT 3
>> + #define SYNCM_BIT 2
>> + #define MS_BIT 1
> Instead of these *_BIT defines as plain numbers you can defined them using
> BIT() macro and use macros in place instead of
> enum TDM_CLKPOL clkpolity;
> enum TDM_ELM elm;
> enum TDM_SYNCM syncm;
> enum TDM_MASTER_SLAVE_MODE ms_mode;
Something happens w/ my email client and I sent this section by accident.
Thus you can ignore it.
Powered by blists - more mailing lists