linux-kernel - Re: [PATCH v5] usb: typec: intel_pmc_mux: Expose IOM port status to debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023053013-playhouse-dad-1444@gregkh>
Date:   Tue, 30 May 2023 10:44:48 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Rajat Khandelwal <rajat.khandelwal@...ux.intel.com>
Cc:     heikki.krogerus@...ux.intel.com, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] usb: typec: intel_pmc_mux: Expose IOM port status to
 debugfs

On Tue, May 30, 2023 at 03:06:15PM +0530, Rajat Khandelwal wrote:
> Hi,
> 
> On 5/30/2023 2:57 PM, Greg KH wrote:
> > On Tue, May 30, 2023 at 02:45:03PM +0530, Rajat Khandelwal wrote:
> > > Hi,
> > > 
> > > On 5/29/2023 7:48 PM, Greg KH wrote:
> > > > On Wed, May 24, 2023 at 04:17:54PM +0530, Rajat Khandelwal wrote:
> > > > > IOM status has a crucial role during debugging to check the
> > > > > current state of the type-C port.
> > > > > There are ways to fetch the status, but all those require the
> > > > > IOM port status offset, which could change with platform.
> > > > > 
> > > > > Make a debugfs directory for intel_pmc_mux and expose the status
> > > > > under it per port basis.
> > > > > 
> > > > > Signed-off-by: Rajat Khandelwal <rajat.khandelwal@...ux.intel.com>
> > > > > Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > > > Does not apply to my tree :(
> > > I have pushed the patch on top of the Linus's tree.
> > > Had a quick check with the USB Linux tree and seems like its a lot
> > > behind?
> > What branch did you use?
> > 
> > Please use the usb-next branch of
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git, which as
> > of right now, is at 6.4-rc4 + a bunch of USB-specific patches.
> 
> I see. There is one commit additional in the usb-next tree:
> ef0a3642b320 usb: typec: intel_pmc_mux: Convert to platform remove callback returning void

One?  I count a lot more:

$ git log --oneline main..usb-next | wc -l
143

> Anyways, do you want me to re-work the patch for the usb-next branch?

Given that I can not take the patch as-is, it's up to you to rebase it
if you wish to have it accepted.

Isn't this all covered in the Intel kernel developer training class?

thanks,

greg k-h