linux-kernel - Re: [PATCH v4 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZfWF5Bq5id_JyDe2GLc7OojiD7R6g2ZiHswPD3D_UT_w@mail.gmail.com>
Date:   Tue, 30 May 2023 13:36:55 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jerome Neanne <jneanne@...libre.com>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        Tony Lindgren <tony@...mide.com>, Lee Jones <lee@...nel.org>,
        khilman@...libre.com, msp@...libre.com, francesco@...cini.it,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-omap@...r.kernel.org,
        Jonathan Cormier <jcormier@...ticallink.com>
Subject: Re: [PATCH v4 1/2] gpio: tps65219: add GPIO support for TPS65219 PMIC

On Tue, May 30, 2023 at 10:00 AM Jerome Neanne <jneanne@...libre.com> wrote:

> Add support for TPS65219 PMICs GPIO interface.
>
> 3 GPIO pins:
> - GPIO0 only is IO but input mode reserved for MULTI_DEVICE_ENABLE usage
> - GPIO1 and GPIO2 are Output only and referred as GPO1 and GPO2 in spec
>
> GPIO0 is statically configured as input or output prior to Linux boot.
> it is used for MULTI_DEVICE_ENABLE function.
> This setting is statically configured by NVM.
> GPIO0 can't be used as a generic GPIO (specification Table 8-34).
> It's either a GPO when MULTI_DEVICE_EN=0 or a GPI when MULTI_DEVICE_EN=1.
>
> Datasheet describes specific usage for non standard GPIO.
> Link: https://www.ti.com/lit/ds/symlink/tps65219.pdf
>
> Co-developed-by: Jonathan Cormier <jcormier@...ticallink.com>
> Signed-off-by: Jonathan Cormier <jcormier@...ticallink.com>
> Signed-off-by: Jerome Neanne <jneanne@...libre.com>

I agree with Andy's review comments, so fix these.
Once those are fixed you can add my:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij