linux-kernel - Re: [cocci] [PATCH] Coccinelle: kmerr: increase check list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7f63dd13-f69a-8171-90f7-5a4f46ed5790@inria.fr>
Date:   Tue, 30 May 2023 14:26:09 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     Markus Elfring <Markus.Elfring@....de>
cc:     Claudiu Beznea <claudiu.beznea@...rochip.com>, cocci@...ia.fr,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...ia.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [cocci] [PATCH] Coccinelle: kmerr: increase check list



On Tue, 30 May 2023, Markus Elfring wrote:

> …
> > +++ b/scripts/coccinelle/null/kmerr.cocci
> …
> > @@ -51,7 +51,7 @@ position any withtest.p;
> >  identifier f;
> >  @@
> >
> > -x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
> > +x@p1 = \(kmalloc\|devm_kmalloc\|kmalloc_array\|devm_kmalloc_array\|krealloc_array\|kzalloc\|devm_kzalloc\|kcalloc\|devm_kcalloc\|kasprintf\|devm_kasprintf\|kstrdup\|kstrdup_const\)(...);
> >  ...
> >  x1@p = f@p2(...);
> >  if (!x1) S
>
> Can it be nicer to specify desired function names on multiple lines
> for such a SmPL disjunction?
>
> Would you sort them according to their call probability?

Please don't follow either of these suggestions.

julia