linux-kernel - Re: [PATCH V1] block: Fix null pointer dereference issue on struct io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7d92802-8403-874d-0cf5-d492e3ea96ae@huaweicloud.com>
Date:   Tue, 30 May 2023 21:24:36 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Pradeep Pragallapati <quic_pragalla@...cinc.com>,
        Yu Kuai <yukuai1@...weicloud.com>, axboe@...nel.dk
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH V1] block: Fix null pointer dereference issue on struct
 io_cq

Hi,

在 2023/05/30 21:15, Pradeep Pragallapati 写道:
> Hi,
> 
> On 5/22/2023 11:49 AM, Pradeep Pragallapati wrote:
>>
>> On 5/18/2023 6:14 PM, Yu Kuai wrote:
>>> Hi,
>>>
>>> 在 2023/05/18 20:16, Yu Kuai 写道:
>>>
>>>> @@ -173,18 +171,17 @@ void ioc_clear_queue(struct request_queue *q)
>>>>   {
>>>>          LIST_HEAD(icq_list);
>>>>
>>>> +       rcu_read_lock();
>>>
>>> Sorry that I realized this is still not enough, following list_empty()
>>> and list_entry() can still concurrent with list_del(). Please try the
>>> following patch:
>> sure will try and update the results.
> 
> 
> At least for 80+hrs of testing, i didn't see the issue reproduced. seems 
> like it is helping my case.

Thanks for the test, I'll send a patch soon.

Kuai