linux-kernel - Re: [PATCH v2 1/3] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230531164556.000027e9@Huawei.com>
Date:   Wed, 31 May 2023 16:45:56 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Junhao He <hejunhao3@...wei.com>
CC:     <will@...nel.org>, <linux-kernel@...r.kernel.org>,
        <mark.rutland@....com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-doc@...r.kernel.org>, <linuxarm@...wei.com>,
        <yangyicong@...wei.com>, <shenyang39@...wei.com>,
        <prime.zeng@...ilicon.com>
Subject: Re: [PATCH v2 1/3] drivers/perf: hisi: Add support for HiSilicon
 H60PA and PAv3 PMU driver

On Wed, 31 May 2023 18:46:23 +0800
Junhao He <hejunhao3@...wei.com> wrote:

> Compared to the original PA device, H60PA offers higher bandwidth.
> The H60PA is a new device and we use HID to differentiate them.
> 
> The events supported by PAv3 and PAv2 are different. They use the
> same HID. The PMU version register is used in the driver to
> distinguish different versions.
> 
> For each H60PA PMU, except for the overflow interrupt register, other
> functions of the H60PA PMU are the same as the original PA PMU module.
> It has 8-programable counters and each counter is free-running.
> Interrupt is supported to handle counter (64-bits) overflow.
> 
> Signed-off-by: Junhao He <hejunhao3@...wei.com>

Hi,

I would have slightly preferred to see the refactoring done as a first
patch and then the new device supported added in a second, but as that
second patch would only be a few lines I don't mind that much.

The result looks fine to me.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>