linux-kernel - Re: [PATCH] blk-ioc: protect ioc_destroy_icq() by 'queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <168555007304.194776.14532611731698933970.b4-ty@kernel.dk>
Date:   Wed, 31 May 2023 10:21:13 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     hch@....de, dlemoal@...nel.org, quic_pragalla@...cinc.com,
        Yu Kuai <yukuai1@...weicloud.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] blk-ioc: protect ioc_destroy_icq() by 'queue_lock'


On Wed, 31 May 2023 15:34:35 +0800, Yu Kuai wrote:
> Currently, icq is tracked by both request_queue(icq->q_node) and
> task(icq->ioc_node), and ioc_clear_queue() from elevator exit is not
> safe because it can access the list without protection:
> 
> ioc_clear_queue			ioc_release_fn
>  lock queue_lock
>  list_splice
>  /* move queue list to a local list */
>  unlock queue_lock
>  /*
>   * lock is released, the local list
>   * can be accessed through task exit.
>   */
> 
> [...]

Applied, thanks!

[1/1] blk-ioc: protect ioc_destroy_icq() by 'queue_lock'
      commit: 2dea233fdc6a00e53bf2ee5cd4b6fca353fd81f8

Best regards,
-- 
Jens Axboe