linux-kernel - Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d403e841-7a86-1f07-c634-1990902826f1@linaro.org>
Date:   Wed, 31 May 2023 19:10:12 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>
Cc:     Marijn Suijten <marijn.suijten@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit

On 31/05/2023 19:05, Konrad Dybcio wrote:
> 
> 
> On 31.05.2023 19:03, Krzysztof Kozlowski wrote:
>> On 31/05/2023 18:33, Konrad Dybcio wrote:
>>> MSM8998's BWMON counts in megabytes. Fix it.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
>>> ---
>>>  drivers/soc/qcom/icc-bwmon.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> If this is
>> https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/
>> (and QLT 1872) then add reported-by tag.
> It's not, I fired up 8998, added debug prints and ran mybw.
> 
>>
>> Change seems logical, although not really documented (a bit
>> contradictory information for sdm845), so assuming this was really tested:
> It's not for sdm845, after the last cleanup both BWMONs on that
> one got its own driver data struct.

Ah, ok, Acks stays :)

Best regards,
Krzysztof