linux-kernel - Re: [PATCH] ocfs2: check new file size on fallocate call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGe7X7kxfrTvg0s3JGasnhFOLFS9FR7uTjwp+YGG7hTNi2UULw@mail.gmail.com>
Date:   Tue, 30 May 2023 20:32:20 -0700
From:   Mark Fasheh <mark@...heh.com>
To:     Luís Henriques <lhenriques@...e.de>
Cc:     Joel Becker <jlbec@...lplan.org>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Heming Zhao <heming.zhao@...e.com>, ocfs2-devel@....oracle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2: check new file size on fallocate call

On Mon, May 29, 2023 at 8:26 AM Luís Henriques <lhenriques@...e.de> wrote:
>
> When changing a file size with fallocate() the new size isn't being
> checked.  In particular, the FSIZE ulimit isn't being checked, which makes
> fstest generic/228 fail.  Simply adding a call to inode_newsize_ok() fixes
> this issue.
>
> Signed-off-by: Luís Henriques <lhenriques@...e.de>

Looks good, thanks Luis.

Reviewed-by: Mark Fasheh <mark@...heh.com>