linux-kernel - Re: [PATCH 4/7] arm64: dts: ti: k3-j7200-mcu: Add mcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230531173906.zznrzuxfytk5feun@spied>
Date:   Wed, 31 May 2023 12:39:06 -0500
From:   Nishanth Menon <nm@...com>
To:     "Kumar, Udit" <u-kumar1@...com>
CC:     Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Tero Kristo <kristo@...nel.org>,
        Vignesh Raghavendra <vigneshr@...com>,
        Nitin Yadav <n-yadav@...com>, Andrew Davis <afd@...com>
Subject: Re: [PATCH 4/7] arm64: dts: ti: k3-j7200-mcu: Add mcu_secproxy

On 22:37-20230531, Kumar, Udit wrote:
[...]
> > +	secure_proxy_mcu: mailbox@...80000 {
> I think, we should start name as  mailbox@...80000
> > +		compatible = "ti,am654-secure-proxy";
> > +		#mbox-cells = <1>;
> > +		reg-names = "target_data", "rt", "scfg";
> > +		reg = <0x0 0x2a480000 0x0 0x80000>,
> > +		      <0x0 0x2a380000 0x0 0x80000>,
> > +		      <0x0 0x2a400000 0x0 0x80000>;
> 
> I think, we should have increasing order for reg. Unless there is some
> strong reason to keep in this way.

Binding is defined this way - the items section in the binding
enforces the order. As a result the first reg entry(target_data)
address causes the node name.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D