linux-kernel - Re: [PATCH] net: pch_gbe: Allow build on MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHfBIkdXeP5rc7Lf@corigine.com>
Date:   Wed, 31 May 2023 23:50:26 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Jiaxun Yang <jiaxun.yang@...goat.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: pch_gbe: Allow build on MIPS_GENERIC kernel

[ Fixed Jakub's email address ]

On Tue, May 30, 2023 at 04:03:01PM +0100, Jiaxun Yang wrote:
> MIPS Boston board, which is using MIPS_GENERIC kernel is using
> EG20T PCH and thus need this driver.
> 
> Note that CONFIG_PCH_GBE is selected in arch/mips/configs/generic/
> board-boston.config for a while, some how it's never wired up
> in Kconfig.
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@...goat.com>
> ---
> Netdev maintainers, is it possible to squeeze this tiny patch into
> fixes tree?

Hi Jianxun Yang,

with this patch applied on top of net [1] I see the following.
Am I doing something wrong?

ARCH=mips

$ make defconfig
CONFIG: mips-gcc-12.2.0
*** Default configuration is based on target '32r2el_defconfig'
Using ./arch/mips/configs/generic_defconfig as base
Merging arch/mips/configs/generic/32r2.config
Merging arch/mips/configs/generic/el.config
Merging ./arch/mips/configs/generic/board-boston.config
Merging ./arch/mips/configs/generic/board-marduk.config
Merging ./arch/mips/configs/generic/board-ni169445.config
Merging ./arch/mips/configs/generic/board-ocelot.config
Merging ./arch/mips/configs/generic/board-ranchu.config
Merging ./arch/mips/configs/generic/board-sead-3.config
Merging ./arch/mips/configs/generic/board-virt.config
Merging ./arch/mips/configs/generic/board-xilfpga.config

WARNING: unmet direct dependencies detected for PTP_1588_CLOCK_PCH
  Depends on [n]: (X86_32 || COMPILE_TEST [=n]) && HAS_IOMEM [=y] && PCI [=y] && NET [=y] && PTP_1588_CLOCK [=y]
  Selected by [y]:
  - PCH_GBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_OKI [=y] && PCI [=y] && (MIPS_GENERIC [=y] || X86_32 || COMPILE_TEST [=n]) && PTP_1588_CLOCK [=y]
#
# configuration written to .config
#

Other than the warning a kernel build with this config seemed to work fine

[1] 7ba0732c805f ("Merge branch 'selftests-mptcp-skip-tests-not-supported-by-old-kernels-part-1'")
    https://git.kernel.org/netdev/net/c/7ba0732c805f


Also, if the patch is targeted at 'net' then that should be noted in the
subject.

	Subject: [PATCH net] ...

And 'pch_gbe: ' is probably a slightly better prefix.

	Subject: [PATCH net] pch_gbe: ...

...