linux-kernel - Re: [PATCH net v3] net: ipa: Use correct value for IPA_STATUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZHfFK0+lgv2pSkFb@corigine.com>
Date:   Thu, 1 Jun 2023 00:07:39 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Bert Karwatzki <spasswolf@....de>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, elder@...nel.org, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] net: ipa: Use correct value for IPA_STATUS_SIZE

On Wed, May 31, 2023 at 12:36:19PM +0200, Bert Karwatzki wrote:
> IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement
> for the size of the removed struct ipa_status which had size
> sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.
> 
> Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
> Signed-off-by: Bert Karwatzki <spasswolf@....de>
> ---
>  drivers/net/ipa/ipa_endpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c
> index 2ee80ed140b7..afa1d56d9095 100644
> --- a/drivers/net/ipa/ipa_endpoint.c
> +++ b/drivers/net/ipa/ipa_endpoint.c
> @@ -119,7 +119,7 @@ enum ipa_status_field_id {
>  };
> 
>  /* Size in bytes of an IPA packet status structure */
> -#define IPA_STATUS_SIZE			sizeof(__le32[4])
> +#define IPA_STATUS_SIZE			sizeof(__le32[8])
> 
>  /* IPA status structure decoder; looks up field values for a structure */
>  static u32 ipa_status_extract(struct ipa *ipa, const void *data,
> --
> 2.40.1
> 
> As none of you seem to be in Europe, I'll do another attempt, this time
> with git send-email.

This looks good to me.

Reviewed-by: Simon Horman <simon.horman@...igine.com>

(somewhere in Europe)