linux-kernel - RE: [PATCH] scsi: ufs: core: Do not open code SZ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 May 2023 05:05:35 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "keosung.park@...sung.com" <keosung.park@...sung.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: core: Do not open code SZ_x

> >int ufshcd_memory_alloc(struct ufs_hba *hba)
> >
> >       /*
> >        * Allocate memory for UTP Transfer descriptors
> >-       * UFSHCI requires 1024 byte alignment of UTRD
> >+       * UFSHCI requires 1KB alignment of UTRD
> >        */
> >       utrdl_size = (sizeof(struct utp_transfer_req_desc) * hba->nutrs);
> >       hba->utrdl_base_addr = dmam_alloc_coherent(hba->dev, @@ -3773,7
> >+3773,7 @@ static int ufshcd_memory_alloc(struct ufs_hba *hba)
> >                                                  &hba->utrdl_dma_addr,
> >                                                  GFP_KERNEL);
> >       if (!hba->utrdl_base_addr ||
> >-          WARN_ON(hba->utrdl_dma_addr & (1024 - 1))) {
> >+          WARN_ON(hba->utrdl_dma_addr & (SZ_1K - 1))) {
> 
> How about changing the UTMRD part inside ufshcd_memory_alloc() as well?
Oops - missed that.
Thanks,
Avri

> 
> Best Regards,
> Keoseong