linux-kernel - RE: [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL0PR04MB6564BC43385D546E4F488542FC489@BL0PR04MB6564.namprd04.prod.outlook.com>
Date:   Wed, 31 May 2023 05:30:12 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Robert Marko <robimarko@...il.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "windhl@....com" <windhl@....com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Bean Huo (beanhuo)" <beanhuo@...ron.com>
Subject: RE: [PATCH] mmc: core: disable TRIM on Micron MTFC4GACAJCN-1M

+Bean

Thanks,
Avri

> It seems that Micron MTFC4GACAJCN-1M despite advertising TRIM support
> does not work when the core is trying to use REQ_OP_WRITE_ZEROES.
> 
> We are seeing the following errors in OpenWrt under 6.1 on Qnap Qhora
> 301W that we did not previously have and tracked it down to
> REQ_OP_WRITE_ZEROES:
> [   18.085950] I/O error, dev loop0, sector 596 op 0x9:(WRITE_ZEROES) flags
> 0x800 phys_seg 0 prio class 2
> 
> Disabling TRIM makes the error go away, so lets add a quirk for this eMMC to
> disable TRIM.
> 
> Signed-off-by: Robert Marko <robimarko@...il.com>
> ---
>  drivers/mmc/core/quirks.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index
> 29b9497936df..77caa0c903f8 100644
> --- a/drivers/mmc/core/quirks.h
> +++ b/drivers/mmc/core/quirks.h
> @@ -100,6 +100,13 @@ static const struct mmc_fixup __maybe_unused
> mmc_blk_fixups[] = {
>         MMC_FIXUP("V10016", CID_MANFID_KINGSTON, CID_OEMID_ANY,
> add_quirk_mmc,
>                   MMC_QUIRK_TRIM_BROKEN),
> 
> +       /*
> +        * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to
> +        * support being used to offload WRITE_ZEROES.
> +        */
> +       MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc,
> +                 MMC_QUIRK_TRIM_BROKEN),
> +
>         /*
>          * Some SD cards reports discard support while they don't
>          */
> --
> 2.40.1