linux-kernel - RE: [PATCH 0/6] bus: fsl-mc: Make remove function return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 May 2023 00:01:22 +0000
From:   Leo Li <leoyang.li@....com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
CC:     Stuart Yoder <stuyoder@...il.com>,
        Gaurav Jain <gaurav.jain@....com>,
        Roy Pledge <roy.pledge@....com>,
        "Diana Madalina Craciun (OSS)" <diana.craciun@....nxp.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        Horia Geanta <horia.geanta@....com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Richard Cochran <richardcochran@...il.com>,
        Pankaj Gupta <pankaj.gupta@....com>,
        Alex Williamson <alex.williamson@...hat.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Vinod Koul <vkoul@...nel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "Y.B. Lu" <yangbo.lu@....com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: RE: [PATCH 0/6] bus: fsl-mc: Make remove function return void



> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Sent: Tuesday, May 30, 2023 8:51 AM
> To: Leo Li <leoyang.li@....com>
> Cc: Stuart Yoder <stuyoder@...il.com>; Gaurav Jain
> <gaurav.jain@....com>; Roy Pledge <roy.pledge@....com>; Diana
> Madalina Craciun (OSS) <diana.craciun@....nxp.com>; Eric Dumazet
> <edumazet@...gle.com>; Ioana Ciornei <ioana.ciornei@....com>;
> kvm@...r.kernel.org; Horia Geanta <horia.geanta@....com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Laurentiu
> Tudor <laurentiu.tudor@....com>; Richard Cochran
> <richardcochran@...il.com>; Pankaj Gupta <pankaj.gupta@....com>; Alex
> Williamson <alex.williamson@...hat.com>; linux-arm-
> kernel@...ts.infradead.org; Herbert Xu <herbert@...dor.apana.org.au>;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Vinod Koul
> <vkoul@...nel.org>; linux-crypto@...r.kernel.org; kernel@...gutronix.de;
> Y.B. Lu <yangbo.lu@....com>; dmaengine@...r.kernel.org; linuxppc-
> dev@...ts.ozlabs.org; David S. Miller <davem@...emloft.net>
> Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void
> 
> Hello,
> 
> On Mon, May 08, 2023 at 04:57:00PM -0500, Li Yang wrote:
> > On Mon, May 8, 2023 at 8:44 AM Uwe Kleine-König
> > <u.kleine-koenig@...gutronix.de> wrote:
> > > On Thu, Apr 13, 2023 at 08:00:04AM +0200, Uwe Kleine-König wrote:
> > > > On Wed, Apr 12, 2023 at 09:30:05PM +0000, Leo Li wrote:
> > > > > > On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
> > > > > > > Hello,
> > > > > > >
> > > > > > > many bus remove functions return an integer which is a
> > > > > > > historic misdesign that makes driver authors assume that
> > > > > > > there is some kind of error handling in the upper layers.
> > > > > > > This is wrong however and returning and error code only yields an
> error message.
> > > > > > >
> > > > > > > This series improves the fsl-mc bus by changing the remove
> > > > > > > callback to return no value instead. As a preparation all
> > > > > > > drivers are changed to return zero before so that they don't
> trigger the error message.
> > > > > >
> > > > > > Who is supposed to pick up this patch series (or point out a
> > > > > > good reason for not taking it)?
> > > > >
> > > > > Previously Greg KH picked up MC bus patches.
> > > > >
> > > > > If no one is picking up them this time, I probably can take it
> > > > > through the fsl soc tree.
> > > >
> > > > I guess Greg won't pick up this series as he didn't get a copy of
> > > > it :-)
> > > >
> > > > Browsing through the history of drivers/bus/fsl-mc there is no
> > > > consistent maintainer to see. So if you can take it, that's very
> > > > appreciated.
> > >
> > > My mail was meant encouraging, maybe it was too subtile? I'll try again:
> > >
> > > Yes, please apply, that would be wonderful!
> >
> > Sorry for missing your previous email.  I will do that.  Thanks.
> 
> Either you didn't apply this patch set yet, or your tree isn't in next.
> Both variants would be great to be fixed.
> 
> I have another change pending for drivers/bus/fsl-mc/fsl-mc-bus.c, would be
> great to see these base patches in next first.

I have applied them to the next branch of my tree.  They will be part of the Linux-next soon.

Regards,
Leo