linux-kernel - Re: [PATCH 1/1] kallsyms: add kallsyms_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHbisZ6eGOM0S0oj@bombadil.infradead.org>
Date:   Tue, 30 May 2023 23:01:21 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Maninder Singh <maninder1.s@...sung.com>
Cc:     ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com,
        andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org,
        yhs@...com, kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, thunder.leizhen@...wei.com, boqun.feng@...il.com,
        vincenzopalazzodev@...il.com, ojeda@...nel.org, jgross@...e.com,
        brauner@...nel.org, michael.christie@...cle.com,
        samitolvanen@...gle.com, glider@...gle.com, peterz@...radead.org,
        keescook@...omium.org, stephen.s.brennan@...cle.com,
        alan.maguire@...cle.com, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org, Onkarnath <onkarnath.1@...sung.com>
Subject: Re: [PATCH 1/1] kallsyms: add kallsyms_show_value defination in all
 cases

On Wed, May 31, 2023 at 09:56:00AM +0530, Maninder Singh wrote:
> so bpf_dump_raw_ok check is not changed.

Since you're adding a new file and making no changes to tons of code but
also making somew new changes I can't tell easily what is new or not.
Although I can see we're now adding a false case for bpf_dump_raw_ok()
it would be best if just split this int wo separate patches. One
non-functional, and a second wwone which extends the code.

  Luis