[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8033fb8f9677cf9aae411e97eb554d251ca03011.camel@sipsolutions.net>
Date: Wed, 31 May 2023 08:18:00 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Kees Cook <kees@...nel.org>, kernel test robot <lkp@...el.com>,
Azeem Shaikh <azeemshaikh38@...il.com>,
Maxim Krasnyansky <maxk@....qualcomm.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-hardening@...r.kernel.org,
linux-kernel@...r.kernel.org, Richard Weinberger <richard@....at>,
Anton Ivanov <anton.ivanov@...bridgegreys.com>,
linux-um@...ts.infradead.org
Subject: Re: [PATCH] uml: Replace all non-returning strlcpy with strscpy
> - strlcpy(ifr.ifr_name, pri->dev_name,
> sizeof(ifr.ifr_name));
> + strscpy(ifr.ifr_name, pri->dev_name,
> sizeof(ifr.ifr_name));
>
> > arch/um/os-Linux/drivers/tuntap_user.c: In function 'tuntap_open':
> > > > arch/um/os-Linux/drivers/tuntap_user.c:149:17: error: implicit declaration of function 'strscpy'; did you mean 'strncpy'? [-Werror=implicit-function-declaration]
> > 149 | strscpy(ifr.ifr_name, pri->dev_name, sizeof(ifr.ifr_name));
> > | ^~~~~~~
> > | strncpy
> > cc1: some warnings being treated as errors
>
> Ah, yeah, this is another "not actually in the kernel" cases. Let's ignore this strlcpy for now.
>
Well, strlcpy() isn't part of libc either, so all this would need is to
add it to user.h just like strlcpy() is now?
johannes
Powered by blists - more mailing lists