linux-kernel - Re: [PATCH v7 4/4] dt-bindings: mtd: marvell-nand: Remove deprecated compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230531093326.26b6ced7@xps-13>
Date:   Wed, 31 May 2023 09:33:26 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     richard@....at, vigneshr@...com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        andrew@...n.ch, gregory.clement@...tlin.com,
        sebastian.hesselbarth@...il.com, linux-mtd@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, enachman@...vell.com
Subject: Re: [PATCH v7 4/4] dt-bindings: mtd: marvell-nand: Remove
 deprecated compatibles

Hi Chris,

chris.packham@...iedtelesis.co.nz wrote on Wed, 31 May 2023 11:54:56
+1200:

> Remove compatible values that were marked as deprecated in the old text
> binding.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>  .../devicetree/bindings/mtd/marvell,nand-controller.yaml       | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> index 7cd4a2e99343..80ce854291cb 100644
> --- a/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> +++ b/Documentation/devicetree/bindings/mtd/marvell,nand-controller.yaml
> @@ -18,9 +18,6 @@ properties:
>        - enum:
>            - marvell,armada370-nand-controller
>            - marvell,pxa3xx-nand-controller
> -          - marvell,armada-8k-nand
> -          - marvell,armada370-nand
> -          - marvell,pxa3xx-nand

Not sure what you're doing here? I would actually expect these three
lines to have something along:

                 deprecated: true

and this should be part of the conversion to yaml. Or perhaps I am
missing something?

The rest of the series looks good to me.

>  
>    reg:
>      maxItems: 1


Thanks,
Miquèl