linux-kernel - Re: [PATCH -next] block: fix blktrace debugfs entries leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a3cdcab-362b-1d6e-3988-9c07df4533ec@huaweicloud.com>
Date:   Wed, 31 May 2023 15:42:05 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     Christoph Hellwig <hch@....de>, Yu Kuai <yukuai1@...weicloud.com>
Cc:     ming.lei@...hat.com, axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, yi.zhang@...wei.com,
        yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH -next] block: fix blktrace debugfs entries leak

Hi,

在 2023/05/30 22:29, Christoph Hellwig 写道:
> On Tue, May 30, 2023 at 10:07:54AM +0800, Yu Kuai wrote:
>>> If we don't care about blktrace for passthrough io after del_gendisk(),
>>> and /dev/sg* has separate handling, I think it's better just to check
>>> QUEUE_FLAG_REGISTERED in blk_trace_setup(), and don't enable blktrace
>>> in the first place.
>>
>> Any suggestions about this problem? Should we use separate handling for
>> /dev/sd? Or just free blktrace in blk_free_queue().
> 
> I'd be fine with trying to either remove the /dev/sg blktrace handling
> and / or splitting it up so that it doesn't interact with the main disk
> based one.  I can look into this if you want, or leave it to you.
> 

Ok, I'll send a v2 to free blktrace in disk_release(), in the meantime
I'll take a look how to handle blktrace for /dev/sg.

Thanks,
Kuai
> .
>