[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ecb3728a-575c-942e-ffcb-659f218e0b01@linaro.org>
Date: Wed, 31 May 2023 09:53:56 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Conor Dooley <conor@...nel.org>, matthias.bgg@...nel.org
Cc: rafael@...nel.org, Daniel Lezcano <daniel.lezcano@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
devicetree@...r.kernel.org, Amit Kucheria <amitk@...nel.org>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mediatek@...ts.infradead.org,
Zhang Rui <rui.zhang@...el.com>,
linux-arm-kernel@...ts.infradead.org,
Matthias Brugger <matthias.bgg@...il.com>
Subject: Re: [PATCH 1/2] dt-bindings: thermal: mediatek: Move auxdac binding
to yaml
On 31/05/2023 00:02, Conor Dooley wrote:
> Hey Matthias,
>
> On Tue, May 30, 2023 at 05:04:12PM +0200, matthias.bgg@...nel.org wrote:
>
>> + The MediaTek thermal controller measures the on-SoC temperatures.
>> + This device does not have its own ADC, instead it directly controls
>> + the AUXADC via AHB bus accesses. For this reason this device needs
>> + phandles to the AUXADC. Also it controls a mux in the apmixedsys
>> + register space via AHB bus accesses, so a phandle to the APMIXEDSYS
>> + is also needed.
>
> That double "also" bothers my OCD greatly, but it is a faithful
> conversion.
>
>> + "#thermal-sensor-cells":
>> + const: 1
>
>> -- #thermal-sensor-cells : Should be 0. See Documentation/devicetree/bindings/thermal/thermal-sensor.yaml for a description.
>
> How come this has changed? I didn't see an explanation for it in either
> of the patches.
Yep. Please mention the deviations from pure conversion and if not
obvious - justify them.
Best regards,
Krzysztof
Powered by blists - more mailing lists