linux-kernel - Re: [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cd77fb6-ed45-8f7a-93f4-e795c898168d@collabora.com>
Date:   Wed, 31 May 2023 10:12:53 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Chen-Yu Tsai <wenst@...omium.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Nícolas F . R . A . Prado 
        <nfraprado@...labora.com>, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: mediatek: SVS: Fix MT8192 GPU node name

Il 31/05/23 08:35, Chen-Yu Tsai ha scritto:
> Device tree node names should be generic. The planned device node name
> for the GPU, according to the bindings and posted DT changes, is "gpu",
> not "mali".
> 
> Fix the GPU node name in the SVS driver to follow.
> 
> Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver")
> Signed-off-by: Chen-Yu Tsai <wenst@...omium.org>

Hahaha, I was about to send the same patch! :D

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

> ---
>   drivers/soc/mediatek/mtk-svs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 81585733c8a9..3a2f97cd5272 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -2061,9 +2061,9 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
>   		svsb = &svsp->banks[idx];
>   
>   		if (svsb->type == SVSB_HIGH)
> -			svsb->opp_dev = svs_add_device_link(svsp, "mali");
> +			svsb->opp_dev = svs_add_device_link(svsp, "gpu");
>   		else if (svsb->type == SVSB_LOW)
> -			svsb->opp_dev = svs_get_subsys_device(svsp, "mali");
> +			svsb->opp_dev = svs_get_subsys_device(svsp, "gpu");
>   
>   		if (IS_ERR(svsb->opp_dev))
>   			return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),