linux-kernel - Re: [PATCH v3] pwm: mtk_disp: Fix the disable flow of disp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f75de5e-db68-6ad7-3176-f8143f0df922@collabora.com>
Date:   Wed, 31 May 2023 10:25:03 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Shuijing Li <shuijing.li@...iatek.com>, thierry.reding@...il.com,
        u.kleine-koenig@...gutronix.de, matthias.bgg@...il.com
Cc:     devicetree@...r.kernel.org, linux-pwm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com,
        jitao.shi@...iatek.com, Fei Shao <fshao@...omium.org>
Subject: Re: [PATCH v3] pwm: mtk_disp: Fix the disable flow of disp_pwm

Il 31/05/23 05:10, Shuijing Li ha scritto:
> There is a flow error in the original mtk_disp_pwm_apply() function.
> If this function is called when the clock is disabled, there will be a
> chance to operate the disp_pwm register, resulting in disp_pwm exception.
> Fix this accordingly.
> 
> Fixes: 888a623db5d0 ("pwm: mtk-disp: Implement atomic API .apply()")
> Signed-off-by: Shuijing Li <shuijing.li@...iatek.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> Tested-by: Fei Shao <fshao@...omium.org>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>