linux-kernel - Re: [PATCH net v2] net: ipa: Use the correct value for IPA_STATUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e144386d-e62a-a470-fcf9-0dab6f7ab837@linaro.org>
Date:   Tue, 30 May 2023 20:57:17 -0500
From:   Alex Elder <elder@...aro.org>
To:     Alex Elder <alex.elder@...aro.org>,
        Bert Karwatzki <spasswolf@....de>,
        Simon Horman <simon.horman@...igine.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: ipa: Use the correct value for
 IPA_STATUS_SIZE

On 5/30/23 6:43 PM, Alex Elder wrote:
> On 5/30/23 6:25 PM, Bert Karwatzki wrote:
>>  From 2e5e4c07606a100fd4af0f08e4cd158f88071a3a Mon Sep 17 00:00:00 2001
>> From: Bert Karwatzki <spasswolf@....de>
>> To: davem@...emloft.net
>> To: edumazet@...gle.com
>> To: kuba@...nel.org
>> To: pabeni@...hat.com
>> Cc: elder@...nel.org
>> Cc: netdev@...r.kernel.org
>> Cc: linux-arm-msm@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org
>> Date: Wed, 31 May 2023 00:16:33 +0200
>> Subject: [PATCH net v2] net: ipa: Use correct value for IPA_STATUS_SIZE
>>
>> IPA_STATUS_SIZE was introduced in commit b8dc7d0eea5a as a replacement
>> for the size of the removed struct ipa_status which had size
>> sizeof(__le32[8]). Use this value as IPA_STATUS_SIZE.
> 
> If the network maintainers can deal with your patch, I'm
> OK with it.  David et al if you want something else, please
> say so.

OK, Jakub has spoken...

Bert, I tried before to explain what you needed to do, but it's
still not quite right.  Please contact me privately and we'll
work out how to get this submitted in the proper format.

					-Alex


> Reviewed-by: Alex Elder <elder@...aro.org>
> 
>> Fixes: b8dc7d0eea5a ("net: ipa: stop using sizeof(status)")
>> Signed-off-by: Bert Karwatzki <spasswolf@....de>
>> ---
>>   drivers/net/ipa/ipa_endpoint.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ipa/ipa_endpoint.c 
>> b/drivers/net/ipa/ipa_endpoint.c
>> index 2ee80ed140b7..afa1d56d9095 100644
>> --- a/drivers/net/ipa/ipa_endpoint.c
>> +++ b/drivers/net/ipa/ipa_endpoint.c
>> @@ -119,7 +119,7 @@ enum ipa_status_field_id {
>>   };
>>   /* Size in bytes of an IPA packet status structure */
>> -#define IPA_STATUS_SIZE            sizeof(__le32[4])
>> +#define IPA_STATUS_SIZE            sizeof(__le32[8])
>>   /* IPA status structure decoder; looks up field values for a 
>> structure */
>>   static u32 ipa_status_extract(struct ipa *ipa, const void *data,
>