linux-kernel - Re: [PATCH v2 04/12] dmaengine: fsl-edma: remove v3 from enum edma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZHdCrzKavdjQtfiQ@lizhi-Precision-Tower-5810>
Date:   Wed, 31 May 2023 08:50:55 -0400
From:   Frank Li <Frank.li@....com>
To:     Peng Fan <peng.fan@....nxp.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, peng.fan@....com,
        vkoul@...nel.org, devicetree@...r.kernel.org,
        dmaengine@...r.kernel.org, imx@...ts.linux.dev, joy.zou@....com,
        linux-kernel@...r.kernel.org, robh+dt@...nel.org,
        shenwei.wang@....com
Subject: Re: [PATCH v2 04/12] dmaengine: fsl-edma: remove v3 from enum
 edma_version

On Wed, May 31, 2023 at 02:50:57PM +0800, Peng Fan wrote:
> 
> 
> On 5/30/2023 4:04 AM, Frank Li wrote:
> >   static struct fsl_edma_drvdata imx7ulp_data = {
> > -       .version = v3,
> > +       .version = v1,
> 
> This may confuse people.How about for hardware
> version >= v3, use new flag as yours?

I can use drvflags to distinguish. I checked spec, 7ULP called eDMA2.
Okay, let me change to check drvflags.

Anyways, we should align version with hardware IP version, or not
use it at all.

Frank

> 
> Regards,
> Peng.