linux-kernel - Re: [PATCH] nvme: Increase block size variable size to 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230531130325.GE27468@lst.de>
Date:   Wed, 31 May 2023 15:03:25 +0200
From:   Christoph Hellwig <hch@....de>
To:     Daniel Gomez <da.gomez@...sung.com>
Cc:     Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        Pankaj Raghav <p.raghav@...sung.com>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvme: Increase block size variable size to 32-bit

> +	u32 bs = 1 << ns->lba_shift;

Make that 1 a 1U so that we're not going to run into sign extension
issues when using up all bits in the u32 :)

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>