linux-kernel - Re: [PATCH v2] extcon: Switch i2c drivers back to use .probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20591cc8-8442-b9cb-545e-d5cbca543484@gmail.com>
Date:   Thu, 1 Jun 2023 23:45:24 +0900
From:   Chanwoo Choi <cwchoi00@...il.com>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v2] extcon: Switch i2c drivers back to use .probe()

On 23. 5. 30. 14:17, Uwe Kleine-König wrote:
> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new()
> call-back type"), all drivers being converted to .probe_new() and then
> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter")
> convert back to (the new) .probe() to be able to eventually drop
> .probe_new() from struct i2c_driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello,
> 
> On Mon, May 29, 2023 at 11:48:43PM +0900, Chanwoo Choi wrote:
>> When I tried to apply it, there is conflict for extcon-usbc-tusb320.c
>> extcon-usbc-tusb320.c was already changed to probe_new. 
>> I'd like you to resend it on latest extcon-next branch. Thanks.
> 
> I rebased onto
> git://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/extcon.git extcon-next.
> (It would have helped a bit if you mentioned the URL, I assume you would
> have found it out more quickly than I did.) The relevant difference is a
> conflict with commit 3adbaa30d973 ("extcon: usbc-tusb320: Unregister
> typec port on driver removal") which added a .remove callback in the
> context.
>

Basically, all merged patch should be discussed on mailing list.
As you mention, I already knew that why conflict happen.

So I replied that you need to rebase it on latest extcon-next
and then ask the resend the patch without conflict. 

Applied it.

Thanks,
Chanwoo Choi