linux-kernel - Re: [PATCH] serial: core: Fix probing serial_base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7c857b8-4aa1-cd5d-4c45-392f7ed6857b@samsung.com>
Date:   Thu, 1 Jun 2023 17:09:52 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tony Lindgren <tony@...mide.com>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...el.com>,
        Dhruva Gole <d-gole@...com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        John Ogness <john.ogness@...utronix.de>,
        Johan Hovold <johan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-omap@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: core: Fix probing serial_base_bus devices

On 01.06.2023 16:21, Greg Kroah-Hartman wrote:
> On Thu, Jun 01, 2023 at 05:14:44PM +0300, Tony Lindgren wrote:
>> If a physical serial port device driver uses arch_initcall() we fail to
>> probe the serial_base_bus devices and the serial port tx fails. This is
>> because as serial_base_bus uses module_initcall().
>>
>> Let's fix the issue by changing serial_base_bus to use arch_initcall().
> This will only work if the linking order is such that this will always
> come before the drivers.  Is that the case here?

Yes, serial_base_bus is linked as a second object, just after the 
serial_core. Device drivers come later.


Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland