linux-kernel - Re: [PATCH] accel/ivpu: Use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Jun 2023 17:58:48 +0200
From:   Marco Pagani <marpagan@...hat.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
        Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>,
        Oded Gabbay <ogabbay@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] accel/ivpu: Use struct_size()


On 2023-05-29 15:28, Christophe JAILLET wrote:
> Use struct_size() instead of hand-writing it. It is less verbose, more
> robust and more informative.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Marco Pagani <marpagan@...hat.com>

> ---
>  drivers/accel/ivpu/ivpu_job.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/accel/ivpu/ivpu_job.c b/drivers/accel/ivpu/ivpu_job.c
> index 3c6f1e16cf2f..0a09bba8da24 100644
> --- a/drivers/accel/ivpu/ivpu_job.c
> +++ b/drivers/accel/ivpu/ivpu_job.c
> @@ -289,15 +289,13 @@ ivpu_create_job(struct ivpu_file_priv *file_priv, u32 engine_idx, u32 bo_count)
>  {
>  	struct ivpu_device *vdev = file_priv->vdev;
>  	struct ivpu_job *job;
> -	size_t buf_size;
>  	int ret;
>  
>  	ret = ivpu_rpm_get(vdev);
>  	if (ret < 0)
>  		return NULL;
>  
> -	buf_size = sizeof(*job) + bo_count * sizeof(struct ivpu_bo *);
> -	job = kzalloc(buf_size, GFP_KERNEL);
> +	job = kzalloc(struct_size(job, bos, bo_count), GFP_KERNEL);
>  	if (!job)
>  		goto err_rpm_put;
>