linux-kernel - Re: [PATCH v1 2/7] dt-bindings: timer: gpt: Add i.MX6UL support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230601-sulfide-endeared-10611decfc76@spud>
Date:   Thu, 1 Jun 2023 19:20:54 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Abel Vesa <abelvesa@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Ulf Hansson <ulf.hansson@...aro.org>, kernel@...gutronix.de,
        Peng Fan <peng.fan@....com>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Michael Trimarchi <michael@...rulasolutions.com>,
        Mark Brown <broonie@...nel.org>,
        Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        Anson Huang <Anson.Huang@....com>, Marek Vasut <marex@...x.de>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-input@...r.kernel.org,
        linux-mmc@...r.kernel.org
Subject: Re: [PATCH v1 2/7] dt-bindings: timer: gpt: Add i.MX6UL support

On Thu, Jun 01, 2023 at 12:14:46PM +0200, Oleksij Rempel wrote:
> Add 'fsl,imx6ul-gpt' compatible to resolve the following dtbs_check
> warning:
> /arch/arm/boot/dts/imx6ull-jozacp.dtb: timer@...8000: compatible:
> 'oneOf' conditional failed, one must be fixed:
>     'fsl,imx6ul-gpt' is not one of ['fsl,imx25-gpt', 'fsl,imx50-gpt',
>     'fsl,imx51-gpt', 'fsl,imx53-gpt', 'fsl,imx6q-gpt']
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> index 716c6afcca1f..adf617b8f353 100644
> --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml
> @@ -34,6 +34,10 @@ properties:
>                - fsl,imxrt1050-gpt
>                - fsl,imxrt1170-gpt
>            - const: fsl,imx6dl-gpt
> +      - const: fsl,imx6ul-gpt

Again, why add this as an appears-on its own compatible when it seems to
be used only with a fallback to imx6sx? (In-tree at least)

> +      - items:
> +          - const: fsl,imx6ul-gpt
> +          - const: fsl,imx6sx-gpt
>  
>    reg:
>      maxItems: 1
> -- 
> 2.39.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)