lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230601-deranged-whole-5f5d5b2b6db1@spud>
Date:   Thu, 1 Jun 2023 19:26:03 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Abel Vesa <abelvesa@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Ulf Hansson <ulf.hansson@...aro.org>, kernel@...gutronix.de,
        Peng Fan <peng.fan@....com>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Michael Trimarchi <michael@...rulasolutions.com>,
        Mark Brown <broonie@...nel.org>,
        Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        Anson Huang <Anson.Huang@....com>, Marek Vasut <marex@...x.de>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-input@...r.kernel.org,
        linux-mmc@...r.kernel.org
Subject: Re: [PATCH v1 4/7] dt-bindings: crypto: fsl-dcp: Add i.MX6SL,
 i.MX6SLL, and i.MX6ULL support

On Thu, Jun 01, 2023 at 12:14:48PM +0200, Oleksij Rempel wrote:
> Add support for i.MX6SL, i.MX6SLL, and i.MX6ULL to the 'fsl-dcp' binding
> to address the following dtbs_check warning:
>   imx6ull-jozacp.dtb: crypto@...0000: compatible:0: 'fsl,imx6ull-dcp' is
>     not one of ['fsl,imx23-dcp', 'fsl,imx28-dcp']
>   From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
> 
>   imx6ull-jozacp.dtb: crypto@...0000: compatible: ['fsl,imx6ull-dcp',
>     'fsl,imx28-dcp'] is too long
>   From schema: Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  .../devicetree/bindings/crypto/fsl-dcp.yaml   | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml b/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
> index 99be01539fcd..8af393b9f3ca 100644
> --- a/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
> +++ b/Documentation/devicetree/bindings/crypto/fsl-dcp.yaml
> @@ -11,9 +11,22 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - fsl,imx23-dcp
> -      - fsl,imx28-dcp
> +    oneOf:
> +      - const: fsl,imx23-dcp
> +      - const: fsl,imx28-dcp
> +      - const: fsl,imx6sl-dcp
> +      - const: fsl,imx6sll-dcp
> +      - const: fsl,imx6ull-dcp

Confused again here chief, why allow these to appear on their own if
their are all compatible with the imx28-dcp?

> +      - items:
> +          - enum:
> +              - fsl,imx6sl-dcp
> +              - fsl,imx6sll-dcp
> +              - fsl,imx6ull-dcp
> +          - const: fsl,imx28-dcp
> +      - items:
> +          - enum:
> +              - fsl,imx28-dcp
> +          - const: fsl,imx23-dcp

I don't get this either. Why set the imx23-dcp as the fallback for the
imx28-dcp, when the imx28-dcp is being used as the fallback for the imx6
stuff?

I get the impression that some of the devicetrees should be fixed up,
rather than adding these sorta odd conditions to the bindings.

To me it'd make sense to swap everything that uses imx28-dcp as a
fallback to use imx23-dcp instead, since that is the most generic one?

What am I missing?

Cheers,
Conor.

>  
>    reg:
>      maxItems: 1
> -- 
> 2.39.2
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ