linux-kernel - Re: [PATCH v5 3/9] serial: sc16is7xx: refactor GPIO controller registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230601142724.4fb197fd315e6d360c0d0457@hugovil.com>
Date:   Thu, 1 Jun 2023 14:27:24 -0400
From:   Hugo Villeneuve <hugo@...ovil.com>
To:     m.brock@...mierlo.com
Cc:     gregkh@...uxfoundation.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        jirislaby@...nel.org, jringle@...dpoint.com,
        l.perczak@...lintechnologies.com, tomasz.mon@...lingroup.com,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        Hugo Villeneuve <hvilleneuve@...onoff.com>,
        stable@...r.kernel.org, Lech Perczak <lech.perczak@...lingroup.com>
Subject: Re: [PATCH v5 3/9] serial: sc16is7xx: refactor GPIO controller
 registration

On Thu, 01 Jun 2023 19:28:01 +0200
m.brock@...mierlo.com wrote:

> Hugo Villeneuve schreef op 2023-06-01 18:31:
> > From: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > 
> > In preparation for upcoming patch "fix regression with GPIO
> > configuration". To facilitate review and make code more modular.
> > 
> > Cc: <stable@...r.kernel.org> # 6.1.x
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@...onoff.com>
> > Reviewed-by: Lech Perczak <lech.perczak@...lingroup.com>
> > Tested-by: Lech Perczak <lech.perczak@...lingroup.com>
> > ---
> >  drivers/tty/serial/sc16is7xx.c | 39 ++++++++++++++++++++--------------
> >  1 file changed, 23 insertions(+), 16 deletions(-)
> > 
> > diff --git a/drivers/tty/serial/sc16is7xx.c 
> > b/drivers/tty/serial/sc16is7xx.c
> > index 0c903d44429c..279d7dcb1447 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -1349,6 +1349,26 @@ static int
> > sc16is7xx_gpio_direction_output(struct gpio_chip *chip,
> > 
> >  	return 0;
> >  }
> > +
> > +static int sc16is7xx_setup_gpio_chip(struct device *dev)
> 
> Only one parameter, but...
> 
> > +	ret = sc16is7xx_setup_gpio_chip(dev, mctrl_mask);
> 
> called with two.

Hi Maarten,
sorry about that, I will fix this for V6.

Somehow my automated compile script tested each patch separately, including this one, but the defconfig didn't enable the module sc6is7xx, so the error went unnoticed. I wrongly assumed that "make alldefconfig" enabled all modules, I will instead use "make allyesconfig".

Hugo.