linux-kernel - Re: [PATCH] tmpfs.5: extend with new noswap documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Jun 2023 01:54:25 +0200
From:   Alejandro Colomar <alx.manpages@...il.com>
To:     Luis Chamberlain <mcgrof@...nel.org>, alx@...nel.org,
        linux-man@...r.kernel.org, linux-api@...r.kernel.org
Cc:     hughd@...gle.com, p.raghav@...sung.com, da.gomez@...sung.com,
        rohan.puri@...sung.com, rpuri.linux@...il.com,
        a.manzanares@...sung.com, dave@...olabs.net, yosryahmed@...gle.com,
        keescook@...omium.org, patches@...ts.linux.dev,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tmpfs.5: extend with new noswap documentation

Hi Luis,

On 5/26/23 23:07, Luis Chamberlain wrote:
> Linux commit 2c6efe9cf2d7 ("shmem: add support to ignore swap")
> merged as of v6.4 added support to disable swap for tmpfs mounts.
> 
> This extends the man page to document that.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
> ---
>  man5/tmpfs.5 | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/man5/tmpfs.5 b/man5/tmpfs.5
> index 09d9558985e9..f7f90f112103 100644
> --- a/man5/tmpfs.5
> +++ b/man5/tmpfs.5
> @@ -99,6 +99,11 @@ suffixes like
>  .BR size ,
>  but not a % suffix.
>  .TP
> +.BR noswap "(since Linux 6.4)"
> +.\" commit 2c6efe9cf2d7841b75fe38ed1adbd41a90f51ba0
> +Disables swap. Remounts must respect the original settings.

Please use semantic newlines.  See man-pages(7):
   Use semantic newlines
       In the source of a manual page, new sentences should be started
       on  new  lines,  long  sentences  should be split into lines at
       clause breaks (commas, semicolons, colons, and so on), and long
       clauses should be split at phrase boundaries.  This convention,
       sometimes known as "semantic newlines", makes it easier to  see
       the  effect of patches, which often operate at the level of in‐
       dividual sentences, clauses, or phrases.

Thanks,
Alex

> +By default swap is enabled.
> +.TP
>  .BR mode "=\fImode\fP"
>  Set initial permissions of the root directory.
>  .TP

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5


Download attachment "OpenPGP_signature" of type "application/pgp-signature" (834 bytes)