linux-kernel - Re: [PATCH v2 2/4] riscv: vmlinux-xip.lds.S: remove .alternative section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJF2gTS1EcEw0VWGgd-bezKh=s7zPnFBdyuJc1wuH_SXEwoXbA@mail.gmail.com>
Date:   Thu, 1 Jun 2023 12:43:00 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Jisheng Zhang <jszhang@...nel.org>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Arnd Bergmann <arnd@...db.de>, linux-riscv@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH v2 2/4] riscv: vmlinux-xip.lds.S: remove .alternative section

Reviewed-by: Guo Ren <guoren@...nel.org>

On Wed, May 24, 2023 at 1:10 AM Jisheng Zhang <jszhang@...nel.org> wrote:
>
> ALTERNATIVE mechanism can't work on XIP, and this is also reflected by
> below Kconfig dependency:
>
> RISCV_ALTERNATIVE
>         ...
>         depends on !XIP_KERNEL
>         ...
>
> So there's no .alternative section at all for XIP case, remove it.
>
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
>  arch/riscv/kernel/vmlinux-xip.lds.S |   6 ------
>  1 files changed, 6 deletions(-)
>
> diff --git a/arch/riscv/kernel/vmlinux-xip.lds.S b/arch/riscv/kernel/vmlinux-xip.lds.S
> index eab9edc3b631..50767647fbc6 100644
> --- a/arch/riscv/kernel/vmlinux-xip.lds.S
> +++ b/arch/riscv/kernel/vmlinux-xip.lds.S
> @@ -98,12 +98,6 @@ SECTIONS
>                 __soc_builtin_dtb_table_end = .;
>         }
>
> -       . = ALIGN(8);
> -       .alternative : {
> -               __alt_start = .;
> -               *(.alternative)
> -               __alt_end = .;
> -       }
>         __init_end = .;
>
>         . = ALIGN(16);
> --
> 2.40.1
>


-- 
Best Regards
 Guo Ren